this works with melee, ranged weapons and to hit spells as long as you have advantage? So an elven champion would get 3 dice rolls to roll a 19 or 20 each time he has advantage? I'm understanding this correctly right?
Correct, it does not need to be Dexterity-based overall, but I was referring specifically to his champion character. Who is not making Int/Wis/Cha attacks unless he has multiclassed. He cannot use Elven Accuracy with a Strength attack, only Dexterity. It's also ANY attack roll, so a melee spell attack does in fact count. It should also be noted that spells like booming blade and green-flame blade require you to make a melee weapon attack as part of the spell, so they do in fact work with EA as long as you're using a Dexterity-based weapon.
Correct, it does not need to be Dexterity-based overall, but I was referring specifically to his champion character. Who is not making Int/Wis/Cha attacks unless he has multiclassed. He cannot use Elven Accuracy with a Strength attack, only Dexterity. It's also ANY attack roll, so a melee spell attack does in fact count. It should also be noted that spells like booming blade and green-flame blade require you to make a melee weapon attack as part of the spell, so they do in fact work with EA as long as you're using a Dexterity-based weapon.
Correct, it does not need to be Dexterity-based overall, but I was referring specifically to his champion character. Who is not making Int/Wis/Cha attacks unless he has multiclassed. He cannot use Elven Accuracy with a Strength attack, only Dexterity. It's also ANY attack roll, so a melee spell attack does in fact count. It should also be noted that spells like booming blade and green-flame blade require you to make a melee weapon attack as part of the spell, so they do in fact work with EA as long as you're using a Dexterity-based weapon.
Elven Accuracy can use any non strength non constitution attack modifier.
Champion's improved critical requires a weapon attack, which precludes spell attacks. Note that Booming Blade and Green Flame Blade use melee weapon attacks and are valid, but Shocking Grasp is a melee spell attack and not valid.
That's reiterating what Mog stated.
For a single class fighter, this will mandate that the attack be made with dexterity for both clauses to be fulfilled unless the fighter gets Shillelagh to use Wisdom instead (since it would key off of a druid list).
Multiclass opens the following:
At least Fighter Champion 3/Artificer Battlesmith 3 to get Battle Ready for Intelligence.
At least Fighter Champion 3/Druid 1 for Shillelagh to use Wisdom.
At least Fighter Champion 3/Hexblade Warlock 1 or Fighter Champion 3/Warlock Pact of the Tome to get shillelagh, both keying off of Charisma.
Mostly reiterating what was said at first with some clarifications plus the additional ways it could happen.
Apologies, I skipped over his initial statement of 19 or 20 meaning improved critical. I just meant in general. That is correct though, to get a critical on a 19 you have to be using a melee weapon attack, due to improved critical. Jhfffan is also correct in the fact that when counting on improved critical shocking grasp will not count, but would count on a 20, because EA only requires an attack roll that is dex/int/wis/cha.
/e accidentally said elven accuracy required weapon attack, but it is actually attack roll that is dex/int/wis/cha.
I did forget to mention that Hexblade's curse does have a limited duration improved critical that keys off of any attack roll. That would probably be better for the character concept than Champion for spellcasters.
Any time an unfathomably powerful entity sweeps in and offers godlike rewards in return for just a few teensy favors, it’s a scam. Unless it’s me. I’d never lie to you, reader dearest.
Apologies, I skipped over his initial statement of 19 or 20 meaning improved critical. I just meant in general. That is correct though, to get a critical on a 19 you have to be using a melee weapon attack, due to improved critical. Jhfffan is also correct in the fact that when counting on improved critical shocking grasp will not count, but would count on a 20, because EA only requires weapon attacks.
Elven Accuracy only requires an attack roll, Shocking Grasp requires an attack roll which it would apply to the roll if that character was able to cast Shocking Grasp.
Correct, for EA, but shocking grasp requires a melee spell attack, which means it will not work for Improved Critical. (From being a Champion Fighter like he had stated in his original question that I accidentally glossed over.) (Also I just realized I put weapon attacks instead of attack rolls. Editing that now! Which I realize is why you commented.)
this works with melee, ranged weapons and to hit spells as long as you have advantage? So an elven champion would get 3 dice rolls to roll a 19 or 20 each time he has advantage? I'm understanding this correctly right?
So long as the champion is using a weapon that is dexterity-based and not strength-based, yes.
You do not need to be Dex based, it could be Int, Wisdom, or Charisma also for Elven Accuracy.
For Champion, you need a weapon attack, not a melee spell attack. That should still allow Shadow Blade, Booming Blade, and other spells like these.
Elven Accuracy says:
Correct, it does not need to be Dexterity-based overall, but I was referring specifically to his champion character. Who is not making Int/Wis/Cha attacks unless he has multiclassed. He cannot use Elven Accuracy with a Strength attack, only Dexterity. It's also ANY attack roll, so a melee spell attack does in fact count. It should also be noted that spells like booming blade and green-flame blade require you to make a melee weapon attack as part of the spell, so they do in fact work with EA as long as you're using a Dexterity-based weapon.
Thanks for the clarification
"weapon attacks" of Champion include spells? I thought that wording excluded spells.
Elven Accuracy can use any non strength non constitution attack modifier.
Champion's improved critical requires a weapon attack, which precludes spell attacks. Note that Booming Blade and Green Flame Blade use melee weapon attacks and are valid, but Shocking Grasp is a melee spell attack and not valid.
That's reiterating what Mog stated.
For a single class fighter, this will mandate that the attack be made with dexterity for both clauses to be fulfilled unless the fighter gets Shillelagh to use Wisdom instead (since it would key off of a druid list).
Multiclass opens the following:
At least Fighter Champion 3/Artificer Battlesmith 3 to get Battle Ready for Intelligence.
At least Fighter Champion 3/Druid 1 for Shillelagh to use Wisdom.
At least Fighter Champion 3/Hexblade Warlock 1 or Fighter Champion 3/Warlock Pact of the Tome to get shillelagh, both keying off of Charisma.
Mostly reiterating what was said at first with some clarifications plus the additional ways it could happen.
Apologies, I skipped over his initial statement of 19 or 20 meaning improved critical. I just meant in general. That is correct though, to get a critical on a 19 you have to be using a melee weapon attack, due to improved critical. Jhfffan is also correct in the fact that when counting on improved critical shocking grasp will not count, but would count on a 20, because EA only requires an attack roll that is dex/int/wis/cha.
/e accidentally said elven accuracy required weapon attack, but it is actually attack roll that is dex/int/wis/cha.
I did forget to mention that Hexblade's curse does have a limited duration improved critical that keys off of any attack roll. That would probably be better for the character concept than Champion for spellcasters.
EDIT: had to read some more posts to see what you were talking about.
Any time an unfathomably powerful entity sweeps in and offers godlike rewards in return for just a few teensy favors, it’s a scam. Unless it’s me. I’d never lie to you, reader dearest.
Tasha
Elven Accuracy only requires an attack roll, Shocking Grasp requires an attack roll which it would apply to the roll if that character was able to cast Shocking Grasp.
Correct, for EA, but shocking grasp requires a melee spell attack, which means it will not work for Improved Critical. (From being a Champion Fighter like he had stated in his original question that I accidentally glossed over.) (Also I just realized I put weapon attacks instead of attack rolls. Editing that now! Which I realize is why you commented.)