I stand corrected! Clearly I need to reread through the sage advice. Thank you for the citations!
As far as the <2015 version yeah It'd fail on unarmed strikes and maybe natural weapons and arrows and bolts and good god so many edge cases.
As far as the unarmed strikes are weapons but not A weapon. That's just weird. I'll have to make sure to pay attention to that since I've definitely had a monk/paladin try to smite before.
A far as the spell thing goes -> Also weird. I mean I'll accept it. Its just weird.
Thanks for that I.C. Sun souls! What are they like!