Tools and proficiencies - when advantage? 2024

it says you get advantage when using tools (assuming you are proficent with them) if you are proficient in a relevant skill. the only place i can see this is performance and musical instruments. what are skills would generate advantage in 2024 phb?

You specifically get advantage if you would otherwise use proficiency in both the tool and the corresponding skill.

The next-most-common case after thieves' tools is likely making a Charisma (Performance) check by playing an instrument, with proficiency in both Performance and the instrument https://9apps.ooo/ .

it doesnt state using thieves tools gives advantage 2024 rules changed

For the Lock:

”A Lock comes with a key. Without the key, a creature can use Thieves’ Tools to pick this Lock with a successful DC 15 Dexterity (Sleight of Hand) check.”

So, the relevant skill is Sleight of Hand. If you have proficiency with either Sleight of Hand or with Thieves’ Tools, you can add your PB to the Dexterity check; if you have proficiency with both, you have Advantage. 

It's largely a DM's call thing; Xanathar's Guide to Everything has some suggestions on circumstances where the knowledge tool proficiency implies would integrate with a skill check. In play, it's a matter of looking for opportunities. If you were sent to some location and find it was unexpectedly attacked by forces you don't immediately recognize, you could for instance see if the DM will allow your Smithing tool prof to apply to checking the arms and armor of the attackers for any distinctive characteristics.

In the 2014 rules, Rogues can have expertise with Thieves' Tools, which implied they were a separate skill.

Artificers similarly got expertise with all tools at level 6.

These are gone in the 2024 rules. 

character creator states only proficiencies can be have expertise and jack of all trades now only affects proficiencies not all skill checks ie they nerfed